Introducing Sleep Action for PreStop Hook

[AxeZhan]

Enhancement Description

• One-line enhancement description (can be used as a release note): Add Sleep Action for PreStop Hook
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3960-pod-lifecycle-sleep-action/
• Discussion Link:
  • related issue
  • google doc
• Primary contact (assignee): @AxeZhan @charles-chenzz
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.29
  • Beta release target (x.y): 1.30
  • Stable release target (x.y): 1.33?
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-3960: Introducing Sleep Action for PreStop Hook #3961
  • Code (k/k) update PR(s): Introducing Sleep Action for PreStop Hook kubernetes#119026
  • Docs (k/website) update PR(s):Add information about PodLifecycleSleepAction (KEP3960) website#43428
• Beta
  • KEP (k/enhancements) update PR(s): KEP-3960: promote to beta in 1.30 #4367
  • Code (k/k) update PR(s): [KEP 3960]: graduate PodLifecycleSleepAction to beta kubernetes#122456
  • Docs (k/website) update(s): graduate PodLifecycleSleepAction to beta (KEP 3960) website#45129
• Stable
  • KEP (k/enhancements) update PR(s): [KEP 3960]: Promote PodLifecycleSleepAction to stable  #4866
  • Code (k/k) update PR(s):
    • v1.32(reverted): first try: Graduate PodLifecycleSleepAction to GA kubernetes#128046 and reverted due to flake Revert "Graduate PodLifecycleSleepAction to GA" kubernetes#128627.
    • v1.33:
  • Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[AxeZhan]

/sig node

[AxeZhan]

/cc @thockin

[SergeyKanzhelev]

/milestone v1.28

adding to the milestone for tracking

[Atharva-Shinde]

Hello @AxeZhan 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on Thursday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

• Add approver/s to prod-readiness yaml file
• Change the status of the KEP to implementable
• Get approval from the PRR authors

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[Atharva-Shinde]

/stage alpha

[Atharva-Shinde]

Hey @AxeZhan,
We would just need to update the status inside kep.yaml to implementable instead of provisional as mentioned in my comment above. Please make the change within 24 hours else you would have to file an exception request.
Thanks :)

[SergeyKanzhelev]

this should be updated now. Since there were no material change, can we get it tracked for 1.28?

[Atharva-Shinde]

With all the KEP requirements in place and merged into k/enhancements, the status of this enhancement is now marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

[AdminTurnedDevOps]

Hey @AxeZhan

1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[charles-chenzz]

hi @AdminTurnedDevOps , we currently working on the implement in k/k repos, when we finish it, we will start to add docs. Thanks.

[AxeZhan]

Hey @AdminTurnedDevOps
Thank you for your remind!

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

This definitely needs some new docs :)
I've created a draft pr for place holder, and have updated the link in the Description above, we'll get back to finish the detail after the code changes are done.
We are not very familiar with updating the documentation, so we may need some assistance from your team when the time comes. Thank you in advance!

[AxeZhan]

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is 4 days away at Thursday October 24, 2024 18:00 PDT.

@michellengnx Does kubernetes/website#48295 work?

[dipesh-rawat]

Hello @AxeZhan 👋, v1.32 Enhancements team here

With all the implementation(code related) PRs merged as per the issue description:

• Graduate PodLifecycleSleepAction to GA kubernetes#128046

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

Additionally, please do let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

[AxeZhan]

/remove-milestone v1.32

[dipesh-rawat]

Looks like the code was reverted as part of kubernetes/kubernetes#128627 due to test flakes and the KEP is no longer targeting stable for v1.32 release. Marking this as Removed for v1.32 release cycle now.

/label tracked/no
/remove-label tracked/yes
/milestone clear

[sreeram-venkitesh]

@AlexanderYastrebov @szuecs Wanted to ping you folks regarding the earlier conversation about zero sleep duration. Allowing zero sleep duration is in alpha in v1.32 with #4818. You can use the PodLifecycleSleepActionAllowZero feature gate to enable zero as a valid duration for the sleep action. Please let me know if you have any feedback on this!

[dipesh-rawat]

Hello @AxeZhan 👋, 1.33 Enhancements Lead here.

If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.33 using /milestone v1.33.
Thanks!

/remove-label lead-opted-in

[haircommander]

hm @dipesh-rawat I think we missed one this looks like it's being tracked from sig node side, can you verify it's all set from release team perspective?

/label lead-opted-in
/milestone v1.33

[dipesh-rawat]

@haircommander Unfortunately, the enhancement freeze deadline has passed, and this KEP issue was not lead-opted-in, so it wasn’t added to the tracking board for the v1.33 release. Post-freeze, we've disabled the automated sync job for KEP issues to the tracking board.

To move forward, we’ll need a short exception request filed so the team can add the lead-opted-in label and manually include this in the tracking board.

From a quick scan, I can see the kep.yaml will also need updatelatest-milestone: "v1.33"and stable: v1.33

If you still wish to progress this enhancement in v1.33, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

(cc v1.33 Release Lead @npolshakova)

[haircommander]

oh I'm sorry I misunderstood: #5139 does not move this back to stable, we did not pursue this this release.

/remove-label lead-opted-in
/remove-milestone v1.33

sorry for the noise!