Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about PodLifecycleSleepAction (KEP3960) #43428

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Add information about PodLifecycleSleepAction (KEP3960) #43428

merged 1 commit into from
Oct 19, 2023

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented Oct 11, 2023 •
edited
Loading

PodLifecycleSleepAction updates as part of kubernetes/enhancements#3960

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5aa6dc7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6530967bc8bdec0008035b54

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 11, 2023
@AxeZhan AxeZhan changed the title place holder for kep3960 Add information about PodLifecycleSleepAction (KEP3960) Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language labels Oct 17, 2023
@k8s-ci-robot k8s-ci-robot requested a review from thockin October 17, 2023 16:08
@AxeZhan
Copy link
Member Author

AxeZhan commented Oct 17, 2023

/cc @thockin
Not sure whether if this is enough😢. And if not what should be added, and to where🤦.

@drewhagen drewhagen mentioned this pull request Oct 17, 2023
Open
12 tasks
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 18, 2023

Please squash the PR into a single commit.
The definitions (if appears in the types.go file) will be refreshed by the reference generator. Don't worry about it at the moment.

@tengqm
Copy link
Contributor

tengqm commented Oct 18, 2023

/approve
/hold

The hold can be lifted when the upstream implementation is merged.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2023
@AxeZhan
Copy link
Member Author

AxeZhan commented Oct 18, 2023

The hold can be lifted when the upstream implementation is merged.

What does the upstream implementation refer to? If it's code changes in k/k repo, then we had it merged before. kubernetes/kubernetes#119026

thockin
thockin reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 630a5541065d55bad9bc5a9d5d474b19fba6dd75

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin
Copy link
Member

thockin commented Oct 19, 2023

/remove hold

@thockin
Copy link
Member

thockin commented Oct 19, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1711494 into kubernetes:dev-1.29 Oct 19, 2023
@drewhagen
Copy link
Member

Hello @AxeZhan @thockin 👋, I see there is work in progress with these docs! 👍 Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@AxeZhan
Copy link
Member Author

AxeZhan commented Nov 6, 2023

Hello @AxeZhan @thockin 👋, I see there is work in progress with these docs! 👍 Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

This pr is already merged, so why is this wip? I'm sorry but I'm confused of what to do next.

@drewhagen
Copy link
Member

drewhagen commented Nov 12, 2023 •
edited
Loading

@AxeZhan You are right! My mistake. Please disregard. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@thockin thockin thockin left review comments

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

@mikedanese mikedanese Awaiting requested review from mikedanese

@reylejano reylejano Awaiting requested review from reylejano

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@AxeZhan @tengqm @k8s-ci-robot @thockin @drewhagen