Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatefulSet Support for Updating Volume Claim Template #4650

Open
4 tasks
huww98 opened this issue May 22, 2024 · 13 comments
Open
4 tasks

StatefulSet Support for Updating Volume Claim Template #4650

huww98 opened this issue May 22, 2024 · 13 comments
Assignees
@huww98
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone
v1.33

Comments

@huww98
Copy link

huww98 commented May 22, 2024 •
edited by soltysh
Loading

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 22, 2024
@huww98
Copy link
Author

huww98 commented May 22, 2024 •
edited
Loading

/sig storage

@k8s-ci-robot
Copy link
Contributor

@huww98: The label(s) sig/app cannot be applied, because the repository doesn't have them.

In response to this:

/sig storage
/sig app

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 22, 2024
@huww98
Copy link
Author

huww98 commented May 22, 2024

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label May 22, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps May 22, 2024
This was referenced May 22, 2024
Open
Closed
@ABNER-1
Copy link

ABNER-1 commented May 29, 2024

This feature is highly anticipated and we eagerly await its implementation.

@HoustonPutman HoustonPutman mentioned this issue Jun 14, 2024
Open
@huww98 huww98 mentioned this issue Aug 3, 2024
Closed
horazont pushed a commit to alasca-association/tarook that referenced this issue Oct 22, 2024
Mark immutable config settings as such
dc714d1 
A few of the yk8s config settings in `k8s-service-layer.prometheus` and
 `k8s-service-layer.rook` are actually immutable because they feed into
 the currently immutable `volumeClaimTemplate` field of Kubernetes objects.

Example: The `k8s-service-layer.prometheus.thanos_storegateway_size` yk8s
 config setting feeds into the `storegateway.persistence.size` parameter of the
 bitnami/thanos helm chart which feeds into the `volumeClaimTemplate` field of
 the `thanos-storegateway` statefulset created. That field is currently
 immutable making helm updates with the parameter fail.

Related-to: kubernetes/enhancements#4650
horazont pushed a commit to alasca-association/tarook that referenced this issue Oct 22, 2024
Mark thanos storegateway size immutable
2a5b9a7 
The `k8s-service-layer.prometheus.thanos_storegateway_size` yk8s config
 setting feeds into the `storegateway.persistence.size` parameter of the
 bitnami/thanos helm chart which feeds into the `volumeClaimTemplates` field of
 the `thanos-storegateway` statefulset created. That field is currently
 immutable making helm updates with the parameter fail.

Related-to: kubernetes/enhancements#4650
horazont pushed a commit to alasca-association/tarook that referenced this issue Nov 5, 2024
Mark immutable config settings as such
db8221c 
A few of the yk8s config settings in `k8s-service-layer.prometheus` and
 `k8s-service-layer.rook` are actually immutable because they feed into
 the currently immutable `volumeClaimTemplate` field of Kubernetes objects.

Example: The `k8s-service-layer.prometheus.thanos_storegateway_size` yk8s
 config setting feeds into the `storegateway.persistence.size` parameter of the
 bitnami/thanos helm chart which feeds into the `volumeClaimTemplate` field of
 the `thanos-storegateway` statefulset created. That field is currently
 immutable making helm updates with the parameter fail.

Related-to: kubernetes/enhancements#4650
horazont pushed a commit to alasca-association/tarook that referenced this issue Nov 5, 2024
Mark immutable config settings as such
1d6bb2e 
A few of the yk8s config settings in `k8s-service-layer.prometheus` and
 `k8s-service-layer.rook` are actually immutable because they feed into
 the currently immutable `volumeClaimTemplate` field of Kubernetes objects.

Example: The `k8s-service-layer.prometheus.thanos_storegateway_size` yk8s
 config setting feeds into the `storegateway.persistence.size` parameter of the
 bitnami/thanos helm chart which feeds into the `volumeClaimTemplate` field of
 the `thanos-storegateway` statefulset created. That field is currently
 immutable making helm updates with the parameter fail.

Related-to: kubernetes/enhancements#4650
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 18, 2024
horazont pushed a commit to alasca-association/tarook that referenced this issue Nov 28, 2024
Mark immutable config settings as such
10e85f9 
A few of the yk8s config settings in `k8s-service-layer.prometheus` and
 `k8s-service-layer.rook` are actually immutable because they feed into
 the currently immutable `volumeClaimTemplate` field of Kubernetes objects.

Example: The `k8s-service-layer.prometheus.thanos_storegateway_size` yk8s
 config setting feeds into the `storegateway.persistence.size` parameter of the
 bitnami/thanos helm chart which feeds into the `volumeClaimTemplate` field of
 the `thanos-storegateway` statefulset created. That field is currently
 immutable making helm updates with the parameter fail.

Related-to: kubernetes/enhancements#4650
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 18, 2024
@sathieu sathieu mentioned this issue Jan 8, 2025
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed in SIG Apps Jan 17, 2025
@huww98
Copy link
Author

huww98 commented Jan 21, 2025

/reopen
/remove-lifecycle rotten
I still want to work on this.

@k8s-ci-robot
Copy link
Contributor

@huww98: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten
I still want to work on this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot reopened this Jan 21, 2025
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 21, 2025
@github-project-automation github-project-automation bot moved this from Closed to In Progress in SIG Apps Jan 21, 2025
@soltysh
Copy link
Contributor

soltysh commented Jan 31, 2025

/label lead-opted-in
/milestone v1.33
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 31, 2025
@kannon92
Copy link
Contributor

/assign @huww98

@fykaa
Copy link
Member

fykaa commented Feb 4, 2025

Hello @huww98 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)
/stage alpha

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • Create the KEP readme using the latest template and merge it in the k/enhancements repo.
  • Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@fykaa fykaa moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huww98 huww98

Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
1.33 Enhancements Tracking
Status: At risk for enhancements freeze
SIG Apps
Status: In Progress
Milestone
v1.33
Development

No branches or pull requests
7 participants
@soltysh @kannon92 @huww98 @k8s-ci-robot @ABNER-1 @k8s-triage-robot @fykaa