Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Graceful Node Shutdown KEP 1.20 Alpha #2295

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Update Graceful Node Shutdown KEP 1.20 Alpha #2295

merged 1 commit into from
Jan 26, 2021

Conversation

bobbypage
Copy link
Member

@bobbypage bobbypage commented Jan 20, 2021 •
edited
Loading

Updating the graceful node shutdown KEP implementation history now that the feature is in alpha as of 1.20

Enhancement issue: #2000

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 20, 2021
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 20, 2021
@bobbypage bobbypage force-pushed the update-alpha-shutdown-kep branch 2 times, most recently from 7893ebe to 2749090 Compare January 20, 2021 06:44
@bobbypage
Copy link
Member Author

/retest

@bobbypage bobbypage force-pushed the update-alpha-shutdown-kep branch from 2749090 to c869e2b Compare January 20, 2021 06:46
@kikisdeliveryservice
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2021
@bobbypage
Copy link
Member Author

/cc @mrunalp

@k8s-ci-robot k8s-ci-robot requested a review from mrunalp January 20, 2021 23:38
@bobbypage
Copy link
Member Author

/assign @dchen1107

@mrunalp
Copy link
Contributor

mrunalp commented Jan 22, 2021

/approve

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, derekwaynecarr, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit aa2c61e into kubernetes:master Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 26, 2021
@bobbypage bobbypage mentioned this pull request Mar 18, 2021
Merged
13 tasks
@pacoxu pacoxu mentioned this pull request Oct 12, 2024
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@kikisdeliveryservice kikisdeliveryservice

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
6 participants
@bobbypage @kikisdeliveryservice @mrunalp @derekwaynecarr @k8s-ci-robot @dchen1107