KEP-3140: TimeZone support in CronJob #3375
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
kind/kep
There was a problem hiding this comment.
Minor questions but mostly LGTM. Thank you for the KEP @soltysh
| These goals will help you determine what you need to measure (SLIs) in the next | ||
| question. | ||
| --> | ||
| 99th percentile of cron_job_creation_skew <= 5 seconds per cluster-day. |
There was a problem hiding this comment.
What does cluster-day mean?
There was a problem hiding this comment.
What does cluster-day mean?
Same question
| - Impact of its outage on the feature: | ||
| - Impact of its degraded performance or high-error rates on the feature: | ||
| --> | ||
| None. |
There was a problem hiding this comment.
Perhaps golang TZ package?
| - Impact of its outage on the feature: | ||
| - Impact of its degraded performance or high-error rates on the feature: | ||
| --> | ||
| None. |
There was a problem hiding this comment.
This only works when the kube-controller-manager and kube-apiserver are running, right?
|
Ravi has some good questions on the PRR that should be addressed. The PRR looks good otherwise. |
|
@ravisantoshgudimetla @deads2k comments addressed, ptal |
k8s-ci-robot
added
the
lgtm
|
PRR looks good /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, ravisantoshgudimetla, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
One-line PR description: TimeZone support in CronJob to beta
Issue link: TimeZone support in CronJob #3140
Other comments: none
/assign @janetkuo @ravisantoshgudimetla
for sig-apps review
/assign @deads2k
for prr review