KEP-3705: CloudDualStackNodeIPs to GA #4415
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/lgtm This feature is very specific and niche and it seems also running in production https://github.com/search?q=repo%3Akubernetes%2Fkubernetes%20CloudDualStackNodeIPs&type=code |
k8s-ci-robot
added
the
lgtm
|
/assign @wojtek-t |
| @@ -6,3 +6,5 @@ alpha: | |||
| approver: "wojtek-t" | |||
| beta: | |||
| approver: "wojtek-t" | |||
| stable: | |||
| approver: "wojtek-t" | |||
There was a problem hiding this comment.
@danwinship - There is TODO; do a manual test in the PRR part of the KEP.
Was the test run? Can you please fill this in?
[Other than that, LGTM]
There was a problem hiding this comment.
Reading that now, I'm not even sure what I was planning to test, so I filled that in with more of a "why this question doesn't make sense in this KEP" answer.
There was a problem hiding this comment.
yes - that makes sense - thanks!
danwinship
force-pushed
the
kep-3705-to-ga
branch
from
023f93d to
8e5d60b
Compare
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
One-line PR description: bump to GA
Issue link: Cloud Dual-Stack --node-ip Handling #3705
Other comments:
nothing interesting to report since Beta. "It works." (It's being used in OpenShift at least.)