Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP: Artifact management #791

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

justaugustus
Copy link
Member

This updates the owning SIG to SIG Release, based on the conversations from #721.

Adding the reviewers/approvers:
/assign @justinsb @dims

Commenters:
/cc @calebamiles @cblecker @tpepper @parispittman @Phillels @nikhita

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/pm sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2019
@justaugustus
Copy link
Member Author

Explicit approve from SIG Release.
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2019
@justaugustus
Copy link
Member Author

/assign @thockin

@brendandburns
Copy link
Contributor

@justaugustus I'm not really ok with you hijacking a PR, I've updated the previous PR with the move to sig-release.

@justaugustus
Copy link
Member Author

(chatted with Brendan offline, now that the original is updated)
/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closed this PR.

In response to this:

(chatted with Brendan offline, now that the original is updated)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member Author

/reopen
/assign @brendandburns

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Reopened this PR.

In response to this:

/reopen
/assign @brendandburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brendandburns
Copy link
Contributor

Apparently Prow is confused by my force push.

@justaugustus feel free to merge this PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit bcaae7b into kubernetes:master Jan 31, 2019
@BenTheElder
Copy link
Member

For future reference, github is confused by this, nothing we can do on the Prow end.
This is what you see as a user on the other PR (re-open cannot be clicked):
image

@justaugustus
Copy link
Member Author

@BenTheElder -- appreciate the context. That's what I saw too.
Figured it was because I wasn't a repo admin.

@nikhita
Copy link
Member

nikhita commented Feb 3, 2019

For future reference, github is confused by this, nothing we can do on the Prow end.
This is what you see as a user on the other PR (re-open cannot be clicked):

Just to be clear and have more context, I see this as a repo admin:

screenshot from 2019-02-03 15-43-54

@thockin
Copy link
Member

thockin commented Feb 14, 2019

Thanks for this KEP. I apologize for falling behind in reviews. I assume that this will accumulate the details as they are worked out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants