Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: Update the config KEP #969

Merged
merged 1 commit into from
Apr 22, 2019
Merged

kubeadm: Update the config KEP #969

merged 1 commit into from
Apr 22, 2019

Conversation

rosti
Copy link
Contributor

@rosti rosti commented Apr 17, 2019 •
edited
Loading

Rename and update a bit the KEP for kubeadm config. Most importantly:

  • The KEP is not bound to v1beta1.
  • The notion of v1beta2 was added.
  • Added @fabriziopandini and @neolit123 to the approvers.
  • Added a short implementation history.
  • Added some of the proposed changes for v1beta2.

/assign @fabriziopandini @timothysc @neolit123 @luxas
/cc @kad @detiber @yagonobre @ereslibre

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2019
@neolit123 neolit123 mentioned this pull request Apr 17, 2019
Open
1 task
This was referenced Apr 17, 2019
Closed
Merged
@rosti rosti changed the title kubeadm: proposal for v1beta2 config format [WIP] kubeadm: proposal for v1beta2 config format Apr 18, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2019
@rosti
Copy link
Contributor Author

rosti commented Apr 18, 2019

As per discussion in the kubeadm office hours meeting from yesterday, this KEP is going to be merged with the v1beta1 KEP into a single kubeadm config KEP.

@rosti rosti force-pushed the kubeadm-v1beta2-config branch from 5c35866 to 07b417c Compare April 18, 2019 14:18
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2019
@rosti rosti changed the title [WIP] kubeadm: proposal for v1beta2 config format [WIP] kubeadm: Update the config KEP Apr 18, 2019
timothysc
timothysc requested changes Apr 18, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates on some structure, but looking better.

keps/sig-cluster-lifecycle/kubeadm/0023-kubeadm-config.md Outdated
@@ -1,6 +1,6 @@
---
kep-number: 23
title: Kubeadm config file graduation to v1beta1
title: Kubeadm config file graduation to v1beta2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just say Kubeadm config file format (v1beta2)

keps/sig-cluster-lifecycle/kubeadm/0023-kubeadm-config.md

## Proposal

### Decoupling the kubeadm types from other ComponentConfig types

The `v1alpha2` kubeadm config types currently embeds the ComponentConfig for
The `v1alpha2` kubeadm config types embeds the ComponentConfig for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should move around the subheadings so they are grouped by version

e.g.

  • v1beta1
    • Decoupling the kubeadm types from other ComponentConfig
  • v1beta2
    • (Details ...)

This way as you read it you get the order of when the changes happened.

fabriziopandini
fabriziopandini approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosti
Looks great!
Only few minors, but nothing blocking
+1 on grouping changes by version as suggested by Tim

keps/sig-cluster-lifecycle/kubeadm/0023-kubeadm-config.md Outdated
@@ -179,7 +181,7 @@ be adapted as described by following schemas:
- [kubeadm upgrade node](0023-kubeadm-upgrade-node.png)
- [kubeadm reset](0023-kubeadm-reset.png)

### Use substructures instead of the current "single flat object"
### Use substructures instead of the "single flat object" in v1alpha2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove in v1alpha2 from the title, it is detailed in the next sentence

keps/sig-cluster-lifecycle/kubeadm/0023-kubeadm-config.md Outdated
format. One notable such feature, that was introduced after the release of `v1beta1` is the
[Certificates copy for join --control-plane KEP](./20190122-Certificates-copy-for-kubeadm-join--control-plane.md).

In addition to that, some existing kubeadm feature may not be exposing some settings through the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will simplify into
" In addition to that, some new settings are added to the config format for existing features, improving the original design and addressing user feedbacks.
These includes..."

keps/sig-cluster-lifecycle/kubeadm/0023-kubeadm-config.md Outdated
@@ -240,5 +268,4 @@ the SIG. This comes with a real opportunity cost.

## Alternatives

Graduate kubeadm GA with the current kubeadm config and eventually change afterward
(respecting GA contract rules).
TBD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the paragraph

@rosti rosti force-pushed the kubeadm-v1beta2-config branch from 07b417c to cc90a5f Compare April 19, 2019 10:04
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2019
@rosti
Copy link
Contributor Author

rosti commented Apr 19, 2019

Thanks for the feedback @timothysc and @fabriziopandini !
Updated the PR with all the proposals taken into account.

@rosti rosti force-pushed the kubeadm-v1beta2-config branch from cc90a5f to 8581a9b Compare April 19, 2019 10:12
@rosti rosti changed the title [WIP] kubeadm: Update the config KEP kubeadm: Update the config KEP Apr 19, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2019
@fabriziopandini
Copy link
Member

/approve

timothysc
timothysc approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, rosti, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit bd27595 into kubernetes:master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini approved these changes

@timothysc timothysc timothysc approved these changes

@detiber detiber Awaiting requested review from detiber

@ereslibre ereslibre Awaiting requested review from ereslibre

@kad kad Awaiting requested review from kad

@yagonobre yagonobre Awaiting requested review from yagonobre

Assignees

@timothysc timothysc

@neolit123 neolit123

@fabriziopandini fabriziopandini

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rosti @fabriziopandini @k8s-ci-robot @timothysc @neolit123 @luxas