Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed NFS dns name #295

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Use fixed NFS dns name #295

merged 1 commit into from
Feb 13, 2019

Conversation

IronPan
Copy link
Contributor

@IronPan IronPan commented Jan 18, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot requested review from ahmetb and sebgoa January 18, 2019 09:05
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @IronPan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 18, 2019
@idealhack
Copy link
Member

/ok-to-test
/lgtm
/assign @idvoretskyi

@k8s-ci-robot k8s-ci-robot assigned idealhack and unassigned idealhack Feb 13, 2019
@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 13, 2019
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 13, 2019
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idealhack, idvoretskyi, IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0de07f3 into kubernetes:master Feb 13, 2019
@sdanbury
Copy link

sdanbury commented Sep 2, 2019

@IronPan apologies to mention you randomly. Does k8s handle the NFS server DNS lookup nicely now? Up until now, you have had to specify the IP of the nfs service, rather than reference the DNS name. For example: kubernetes/minikube#3417.

@ensonic
Copy link

ensonic commented Jul 16, 2020

Still does not work. See eg. kubernetes/minikube#3417

@adthonb
Copy link

adthonb commented May 18, 2021

Still doesn't work with DNS, use Service's Cluster-IP instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants