-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow externalTrafficPolicy: Cluster on multinetworking services #2685
Conversation
Removes the constraint that previously restricted externalTrafficPolicy to only `Local` on multinetworking services
Welcome @shouri007! |
Hi @shouri007. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Shouri, when would the DPv2 part of this be in prod? we need to make sure not to allow these services too soon in the L4 controller. |
@mmamczur dpv2 component with the changes is rolled out to prod. We can merge this PR if these changes look good |
@@ -195,35 +195,6 @@ func TestServiceNetwork(t *testing.T) { | |||
service: serviceWithSecondaryNet, | |||
wantErr: "network.Spec.Type=Device is not supported for multinetwork LoadBalancer services, the only supported network type is L3", | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this was a special case we should now change it to expect a valid result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
ok let's merge this now since I don't want surprises later but I don't like how tests were handled here /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmamczur, shouri007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Removes the constraint that previously restricted externalTrafficPolicy to only
Local
on multinetworking services