Rollback queue refactoring

kubernetes · Apr 27, 2017 · 7eee34f · 7eee34f
1 parent 7deb1a2
commit 7eee34f
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/core/pkg/task/queue.go b/core/pkg/task/queue.go
@@ -82,17 +82,16 @@ func (t *Queue) worker() {
 			close(t.workerDone)
 			return
 		}
-		defer t.queue.Done(key)
 
 		glog.V(3).Infof("syncing %v", key)
-		err := t.sync(key)
-		if err == nil {
+		if err := t.sync(key); err != nil {
+			glog.Warningf("requeuing %v, err %v", key, err)
+			t.queue.AddRateLimited(key)
+		} else {
 			t.queue.Forget(key)
-			return
 		}
 
-		glog.Warningf("requeuing %v, err %v", key, err)
-		t.queue.AddRateLimited(key)
+		t.queue.Done(key)
 	}
 }