Chart: use-proxy-protocol default value

[pierluigilenoci]

NGINX Ingress controller version:

v1.6.18
Old stable chart, I know 😞 but this is a copy of the ticket opened on the stable chart repo and unattended for one year helm/charts#14937 I hope that in the meantime the problem has been solved.

Kubernetes version (use kubectl version):

K8s v1.12.7
Helm v2.14.1

Environment:

• Cloud provider or hardware configuration: AWS + ELB
• OS (e.g. from /etc/os-release): Debian GNU/Linux 9 (stretch)
• Kernel (e.g. uname -a): 4.9.0-7-amd64
• Install tools: helm
• Others:
  The configuration is simple: AWS, ELB in front of Nginx
  Kubernetes installed with KOPS
  Installed with helm with this configuration:
  "use-proxy-protocol": "true" "whitelist-source-range": "<list of offices ips>"

What happened:

I activated the value “use-proxy-protocol”: “true” inside the config and I updated the ingress. Unluckily the Cloud LB did not support proxy protocol and so I removed the line and updated again. Nginx has remained set with “use-proxy-protocol”: “true”. To resolve I had to update explicitly the configuration with “use-proxy-protocol”: “false”.

What you expected to happen:

I expected that once the row was removed in the config the ingress would return to the default configuration for "use-proxy-protocol"

How to reproduce it:

Redo the same step that I did.

Anything else we need to know:

Ref: #4305

I appreciate your work!

/kind bug

[tuananhnguyen-ct]

Can you check the content of configmap nginx-ingress-controller before and after you switch the value for use-proxy-protocol? What is the image version you are using? From the chart config we don't need to config a default value for use-proxy-protocol since it's defined as false in nginx-ingress by default.

[pierluigilenoci]

I checked. Of course, I don't have the broken release but, from revision, the only explicit change is use-proxy-protocol: "false". The story went in this way.

Started with chart nginx-ingress-1.6.17 -> updated to nginx-ingress-1.6.18
App version 0.24.1

• No use-proxy-protocol configured (default used)
• Added use-proxy-protocol: "true" (all broken after that)
• Removed use-proxy-protocol (default not used so still true and broken)
• Added explicit use-proxy-protocol: "false" (fixed forcing default)

I know that is defined as false by default but after what I did the ingress was broken. Otherwise, I will not report the problem.

[tuananhnguyen-ct]

After you removed use-proxy-protocol, was the configmap updated (by helm) to remove use-proxy-protocol? Instead of adding use-proxy-protocol: false, can you restart the nginx-ingress-controller to force a reload of configmap and see if it can help?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[pierluigilenoci]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.