Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: NGINX Bandwidth Control #733

Closed
rikatz opened this issue May 18, 2017 · 2 comments · Fixed by #1118
Closed

Feature: NGINX Bandwidth Control #733

rikatz opened this issue May 18, 2017 · 2 comments · Fixed by #1118
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. nginx

Comments

@rikatz
Copy link
Contributor

rikatz commented May 18, 2017

For documentation and implementation:

A new feature would be great in NGINX Ingress Controller: Bandwidth control:

This is done by the Core of NGINX.

http://nginx.org/en/docs/http/ngx_http_core_module.html#limit_rate

The main idea is:

  • A global limit (configured through ConfigMap) that should be used in All VHosts OR
  • If this doesn't exists, a configuration per vhost / ingress done through annotations.

Further implementations can also use the limit_req and limit_conn modules to Limit a per/ip request (but this could cause also a DoS in a lot of clients using a NAT to connect to our service, so should be used carefully).

@aledbf aledbf added nginx enhancement help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 13, 2017
@zjj2wry
Copy link

zjj2wry commented Aug 5, 2017

anyone in process this? i want pick this for starter.

@rikatz
Copy link
Contributor Author

rikatz commented Aug 8, 2017

@zjj2wry I'm pretty busy those days :) Feel free to code this, and ping me in your PR so I can review for you ;)

zjj2wry pushed a commit to zjj2wry/ingress that referenced this issue Aug 12, 2017
zjj2wry pushed a commit to zjj2wry/ingress that referenced this issue Aug 13, 2017
aledbf added a commit that referenced this issue Aug 13, 2017
feat(#733)Support nginx bandwidth control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. nginx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants