Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ingress-nginx to use Lease API #8091

Closed
shafeeqes opened this issue Dec 30, 2021 · 13 comments · Fixed by #8733
Closed

Migrate ingress-nginx to use Lease API #8091

shafeeqes opened this issue Dec 30, 2021 · 13 comments · Fixed by #8733
Assignees
@tao12345666333 @rikatz @shafeeqes
Labels
area/stabilization Work for increasing stabilization of the ingress-nginx codebase kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@shafeeqes
Copy link
Contributor

shafeeqes commented Dec 30, 2021 •
edited
Loading

Support for endpoints and configmaps for leaderelection lock is removed in K8s 1.24 with kubernetes/kubernetes#106852.
More details about the motivation to switch to leases - ref kubernetes/kubernetes#80289.

To preserve the backwards-compatibility, resource lock for migration purposes (endpointsleases, configmapsleases) should be used when switching from the legacy resource locks (endpoints, configmaps)

ingress-nginx is currently using configmaps . We want to migrate this to configmapleases and finally to leases.
@shafeeqes shafeeqes added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 30, 2021
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Dec 30, 2021
@shafeeqes shafeeqes mentioned this issue Dec 30, 2021
Closed
13 tasks
@tao12345666333
Copy link
Member

tao12345666333 commented Dec 31, 2021 •
edited
Loading

/triage accepted

@k8s-ci-robot
Copy link
Contributor

@tao12345666333: The label(s) /label triage/accepted cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

/label triage/accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tao12345666333
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 31, 2021
@rikatz
Copy link
Contributor

rikatz commented Jan 3, 2022

/assign

@shafeeqes
Copy link
Contributor Author

/assign

@shafeeqes shafeeqes mentioned this issue Jan 5, 2022
Closed
8 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 5, 2022
@shafeeqes
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 6, 2022
@BenTheElder BenTheElder mentioned this issue May 12, 2022
Closed
@tao12345666333 tao12345666333 mentioned this issue Jun 6, 2022
Merged
9 tasks
This was referenced Jun 7, 2022
Closed
Merged
@tao12345666333
Copy link
Member

/assign

@longwuyuan longwuyuan mentioned this issue Jun 14, 2022
Closed
@strongjz strongjz added the area/stabilization Work for increasing stabilization of the ingress-nginx codebase label Jun 23, 2022
@strongjz
Copy link
Member

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority labels Jun 23, 2022
@tao12345666333 tao12345666333 mentioned this issue Jun 23, 2022
Merged
9 tasks
@tao12345666333
Copy link
Member

I have submitted a PR #8733

I created resourcelock.MultiLock for lock's migration.
Remove this in subsequent versions and use the Lease API

@shafeeqes
Copy link
Contributor Author

@tao12345666333 Will you open a PR for changing the lock to resourcelock.LeaseLock now that ingress-nginx v1.3.0 is released?

@tao12345666333
Copy link
Member

@shafeeqes Yes! it's on my list, I will do it AFAP.

@tao12345666333 tao12345666333 mentioned this issue Aug 10, 2022
Merged
9 tasks
@tao12345666333
Copy link
Member

#8921 has been merged. I think we've done all the work related to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tao12345666333 tao12345666333

@rikatz rikatz

@shafeeqes shafeeqes

Labels
area/stabilization Work for increasing stabilization of the ingress-nginx codebase kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
6 participants
@strongjz @tao12345666333 @rikatz @k8s-ci-robot @shafeeqes @k8s-triage-robot