hack/generate-deploy-scripts.sh fails due to pathing issues

[Volatus]

This issue concerns development.

What happened:
Running hack/generate-deploy-scripts.sh fails with the following error.

❄️  ./hack/generate-deploy-scripts.sh
Running 1.20 for target provider/exoscale
/Users/xs/Developer/ingress-nginx/deploy/static/provider/exoscale/1.20
sed: can't read /app.kubernetes.io\/managed-by: Helm/d: No such file or directory
sed: can't read /helm.sh/d: No such file or directory
Running 1.20 for target provider/do
/Users/xs/Developer/ingress-nginx/deploy/static/provider/do/1.20
sed: can't read /app.kubernetes.io\/managed-by: Helm/d: No such file or directory
sed: can't read /helm.sh/d: No such file or directory
Running 1.20 for target provider/baremetal
/Users/xs/Developer/ingress-nginx/deploy/static/provider/baremetal/1.20
sed: can't read /app.kubernetes.io\/managed-by: Helm/d: No such file or directory
sed: can't read /helm.sh/d: No such file or directory
Running 1.20 for target provider/kind
/Users/xs/Developer/ingress-nginx/deploy/static/provider/kind/1.20
sed: can't read /app.kubernetes.io\/managed-by: Helm/d: No such file or directory
sed: can't read /helm.sh/d: No such file or directory
Running 1.20 for target provider/cloud
/Users/xs/Developer/ingress-nginx/deploy/static/provider/cloud/1.20
sed: can't read /app.kubernetes.io\/managed-by: Helm/d: No such file or directory
sed: can't read /helm.sh/d: No such file or directory
Running 1.20 for target provider/aws/nlb-with-tls-termination
/Users/xs/Developer/ingress-nginx/deploy/static/provider/aws/nlb-with-tls-termination/1.20
sed: can't read /app.kubernetes.io\/managed-by: Helm/d: No such file or directory
sed: can't read /helm.sh/d: No such file or directory
Running 1.20 for target provider/aws
/Users/xs/Developer/ingress-nginx/deploy/static/provider/aws/1.20
sed: can't read /app.kubernetes.io\/managed-by: Helm/d: No such file or directory
sed: can't read /helm.sh/d: No such file or directory
Running 1.20 for target provider/scw
/Users/xs/Developer/ingress-nginx/deploy/static/provider/scw/1.20
sed: can't read /app.kubernetes.io\/managed-by: Helm/d: No such file or directory
sed: can't read /helm.sh/d: No such file or directory

--- REDACTED

What you expected to happen:
To not error out?

The scripts seem to be reading some wrong paths?

How to reproduce this issue:
Run the script?

[Volatus]

@longwuyuan related to #8824?

[longwuyuan]

I don't think so. I think there is a dependency on a python library somwhete in that script and the name of the library required is not ficumented in release.md. I will check and get back to you. Thanks, ; Long

…

On Mon, 18 Jul, 2022, 3:40 AM Ismayil Mirzali, ***@***.***> wrote: @longwuyuan <https://github.com/longwuyuan> related to #8824 <#8824>? — Reply to this email directly, view it on GitHub <#8828 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWTPFOHVCUUDFJBDBLLVUSAERANCNFSM532NGXDQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tao12345666333]

Hi @Volatus I would like to know what is your OS?

The problem is essentially due to the fact that the sed used under Linux is GNU sed
And sed used under macOS is BSD sed.

The parameters and behavior of the two are not exactly the same.

ingress-nginx/hack/generate-deploy-scripts.sh

Lines 58 to 59 in 1ebb689

	sed -i '' '/app.kubernetes.io\/managed-by: Helm/d' $MANIFEST
	sed -i '' '/helm.sh/d' $MANIFEST

when we using GUN sed, we don't need -i '' , you can just delete this parameter to check if it works.

Also, if you are interested, please submit a PR to fix it

[Volatus]

@tao12345666333 Well I have GNU sed earlier in my $PATH. which sed also points to my installation of GNU sed among the Brew packages. I'll triple check though.

[strongjz]

this may be something we have to check for with the MACOS test or just move the python script to run in a docker container as well.

[strongjz]

/triage accepted
/priority backlog
/area stabilization
/assign @strongjz