-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for nginx-ingress-role RBAC. #2139
Conversation
For the Role named `nginx-ingress-role`, `endpoints` no longer needs or has `create` and `update` permissions. This confused me, so I hope this helps!
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
endpoints
/assign @nicksardo |
Codecov Report
@@ Coverage Diff @@
## master #2139 +/- ##
=======================================
Coverage 36.59% 36.59%
=======================================
Files 68 68
Lines 4837 4837
=======================================
Hits 1770 1770
Misses 2799 2799
Partials 268 268 Continue to review full report at Codecov.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ejamesc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ejamesc thanks! |
What this PR does / why we need it: For the Role named
nginx-ingress-role
,endpoints
no longer needs or hascreate
andupdate
permissions. This confused me, so I hope this helps!Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes confusing documentation that wasn't updated as part of a9168f2Special notes for your reviewer: