Update nginx opentracing zipkin module #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2955 +/- ##
=======================================
Coverage 47.57% 47.57%
=======================================
Files 77 77
Lines 5633 5633
=======================================
Hits 2680 2680
Misses 2600 2600
Partials 353 353Continue to review full report at Codecov.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abbi-gaurav
added a commit
to abbi-gaurav/kyma
that referenced
this pull request
Oct 2, 2018
The upgrade 0.19.0 contains fix for an issue where multiple requests were clubbed in same trace. Refer https://github.com/kubernetes/ingress-nginx/blob/master/Changelog.md, kubernetes/ingress-nginx#2955 and opentracing-contrib/nginx-opentracing#52
crabtree
pushed a commit
to kyma-project/kyma
that referenced
this pull request
Oct 4, 2018
The upgrade 0.19.0 contains fix for an issue where multiple requests were clubbed in same trace. Refer https://github.com/kubernetes/ingress-nginx/blob/master/Changelog.md, kubernetes/ingress-nginx#2955 and opentracing-contrib/nginx-opentracing#52
crabtree
pushed a commit
to kyma-project/kyma
that referenced
this pull request
Oct 4, 2018
The upgrade 0.19.0 contains fix for an issue where multiple requests were clubbed in same trace. Refer https://github.com/kubernetes/ingress-nginx/blob/master/Changelog.md, kubernetes/ingress-nginx#2955 and opentracing-contrib/nginx-opentracing#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR fixes: fixes #2940
The fix is rnburn/zipkin-cpp-opentracing#27