Pass --shell to minikube docker-env #3159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
make dev-env
for those developers who are using non-standard shell, for instance fish.By default,
minikube docker-env
prints exports in the format of your shell. If your shell is fish andminikube docker-env
is executed from a bash script, it will still print the export template in fish format. That makes the script break.The solution is to pass
--shell bash
argument.Side question: what minikube driver do you suggest use on Mac?