Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass --shell to minikube docker-env #3159

Merged
merged 1 commit into from
Sep 29, 2018

Conversation

kirs
Copy link
Contributor

@kirs kirs commented Sep 29, 2018

This fixes make dev-env for those developers who are using non-standard shell, for instance fish.

By default, minikube docker-env prints exports in the format of your shell. If your shell is fish and minikube docker-env is executed from a bash script, it will still print the export template in fish format. That makes the script break.

The solution is to pass --shell bash argument.

Side question: what minikube driver do you suggest use on Mac?

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 29, 2018
@aledbf
Copy link
Member

aledbf commented Sep 29, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, kirs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2018
@aledbf
Copy link
Member

aledbf commented Sep 29, 2018

@kirs thanks!

@k8s-ci-robot k8s-ci-robot merged commit 0f56609 into kubernetes:master Sep 29, 2018
@ElvinEfendi
Copy link
Member

Side question: what minikube driver do you suggest use on Mac?

@kirs I use default vm-driver which is virtualbox, haven't had any issue so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants