add configuration to disable listening on ipv6 #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
Coverage decreased (-0.008%) to 45.37% when pulling 812ff196cfe34e08d0bb86543ad83d9ac3e39a95 on gianrubio:disable-ipv6 into 75124bc on kubernetes:master. |
|
@gianrubio please rebase |
|
I can confirm that this fixes the nginx ingress controllers on our systems where ipv6 is not enabled. |
gianrubio
force-pushed
the
disable-ipv6
branch
3 times, most recently
from
66fc4ff to
48f28bd
Compare
|
@aledbf done! |
aledbf
reviewed
Mar 8, 2017
| @@ -384,7 +384,7 @@ http { | |||
| # Use the port 18080 (random value just to avoid known ports) as default port for nginx. | |||
| # Changing this value requires a change in: | |||
| # https://github.com/kubernetes/contrib/blob/master/ingress/controllers/nginx/nginx/command.go#L104 | |||
| listen [::]:18080 ipv6only=off default_server reuseport backlog={{ .BacklogSize }}; | |||
| listen {{ if not $cfg.DisableIpv6 }}[::]:{{ end }}18080 ipv6only=off default_server reuseport backlog={{ .BacklogSize }}; | |||
There was a problem hiding this comment.
missing {{ if not $cfg.DisableIpv6 }}ipv6only=off{{ end }}
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@gianrubio thanks! |
|
Thanks! |
|
how achive this from helm chart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #368