Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#use-gzip doesn’t say that the default of “use-gzip” is “true”, and instead lists the default of the “gzip-types” field.
Move the
gzip-types
value default from theuse-gzip
to thegzip-types
heading, and link to it from the copy arounduse-gzip
Document that the
use-gzip
default istrue
, matching the style of other configmap items.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #No issue
Special notes for your reviewer:
https://kubernetes.slack.com/archives/CANQGM8BA/p1557933421497900