Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: configmap: use-gzip #4089

Merged
merged 1 commit into from
May 18, 2019
Merged

Docs: configmap: use-gzip #4089

merged 1 commit into from
May 18, 2019

Conversation

ellieayla
Copy link
Contributor

What this PR does / why we need it:

https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#use-gzip doesn’t say that the default of “use-gzip” is “true”, and instead lists the default of the “gzip-types” field.

Move the gzip-types value default from the use-gzip to the gzip-types heading, and link to it from the copy around use-gzip

Document that the use-gzip default is true, matching the style of other configmap items.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

No issue

Special notes for your reviewer:

https://kubernetes.slack.com/archives/CANQGM8BA/p1557933421497900

Move the "gzip-types" value default from the "use-gzip" to the "gzip-types"
heading, and link to it from use-gzip.

Document that the "use-gzip" default is "true", matching the style of other
configmap items.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2019
@aledbf
Copy link
Member

aledbf commented May 18, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2019
@aledbf
Copy link
Member

aledbf commented May 18, 2019

@alanjcastonguay thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanjcastonguay, aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2019
@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

Merging #4089 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4089      +/-   ##
==========================================
- Coverage   57.78%   57.46%   -0.32%     
==========================================
  Files          87       87              
  Lines        6438     6475      +37     
==========================================
+ Hits         3720     3721       +1     
- Misses       2288     2323      +35     
- Partials      430      431       +1
Impacted Files Coverage Δ
internal/ingress/zz_generated.deepcopy.go 0% <0%> (ø) ⬆️
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182b282...f5b0905. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 19501b2 into kubernetes:master May 18, 2019
@ellieayla ellieayla deleted the docs/use-gzip-configmap-defaults branch May 18, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants