-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force GOOS to linux #4113
Force GOOS to linux #4113
Conversation
Hi @wayt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4113 +/- ##
=========================================
Coverage ? 57.76%
=========================================
Files ? 87
Lines ? 6459
Branches ? 0
=========================================
Hits ? 3731
Misses ? 2296
Partials ? 432 Continue to review full report at Codecov.
|
/lgtm |
@wayt thanks! Edit: apologies for the issue introduced by the refactoring |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, wayt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What this PR does / why we need it:
Since #4088
ingress-nginx
is no longer build in a docker container (linux).Which break the build in non linux environment:
the
cgroups
library here is only build on linuxvendor/github.com/opencontainers/runc/libcontainer/cgroups/
=>// +build linux
This change force go to build the binary for a linux environment using go cross platform build.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Cc @ElvinEfendi