Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopify build e2e #4300

Closed
wants to merge 246 commits into from
Closed

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

fmejia97 and others added 30 commits April 9, 2018 12:46
* Fix CI by letting travis build Shopify/ingress image

* Remove static check, coverage and e2e jobs temporarily

* Update .travis/common.sh

* Change registry to Docker Hub

* Add condition to trigger travis image build only on master

* Trigger image push + build on push events only

* Re-add travis CI tests

* Fix CI e2e problem

* Update nginx-ingress:test image

* Trigger NGINX image build by changing  on travis CI ENV

* Update build.sh to be the same as upstream

* Stop building all architectures except amd64

* Re-add docker_tag exists function to common.sh

* Modify docker_tag_exists() method to work with Docker Hub

* Re-add test coverage to CI

* Publish image only on pushes to master

* Undo Makefile ENV changes and add environment changes on travis ci environment settings

* Re-add multiple architecture image builds

* Update common.sh with build checks

* Add new line to EOF: common.sh
* Update nginx image

* Update minikube start script
…fault nginx-configuration state between tests
Extract UpdateConfigmap into e2e framework
LuaJIT is not available for s390x and ppc64le, disable the lua part in nginx.tmpl on these platform.
group client metrics by host?

dest_host tag instead of host tag

add tags to client response time

upstream name instead

not reading json config anymore, relying on env vars

Resort to default instead of crashing

Proper variable scoping in defer.lua and other small fixes

juggling methods around for better division of responsibilities
Emit response StatsD metrics about upstreams when dynamic configuration is enabled
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 9, 2019
@ElvinEfendi ElvinEfendi closed this Jul 9, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 9, 2019
@k8s-ci-robot k8s-ci-robot requested review from aledbf and bowei July 9, 2019 19:55
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
@k8s-ci-robot
Copy link
Contributor

@ElvinEfendi: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-ingress-nginx-test 475dffd link /test pull-ingress-nginx-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ElvinEfendi ElvinEfendi deleted the shopify-build-e2e branch December 18, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.