-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memoize balancer for a request #4365
Conversation
/test pull-ingress-nginx-test |
1 similar comment
/test pull-ingress-nginx-test |
Codecov Report
@@ Coverage Diff @@
## master #4365 +/- ##
=========================================
+ Coverage 58.47% 58.5% +0.03%
=========================================
Files 87 87
Lines 6528 6528
=========================================
+ Hits 3817 3819 +2
+ Misses 2282 2281 -1
+ Partials 429 428 -1
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This is to make sure for a given request context
get_balancer
always returns the same balancer.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #4364Special notes for your reviewer: