Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memoize balancer for a request #4365

Merged
merged 2 commits into from
Jul 26, 2019
Merged

memoize balancer for a request #4365

merged 2 commits into from
Jul 26, 2019

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

This is to make sure for a given request context get_balancer always returns the same balancer.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4364

Special notes for your reviewer:

@ElvinEfendi ElvinEfendi changed the title memoize balancer for a request [WIP] memoize balancer for a request Jul 26, 2019
@k8s-ci-robot k8s-ci-robot requested review from aledbf and bowei July 26, 2019 13:37
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 26, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2019
@ElvinEfendi ElvinEfendi changed the title [WIP] memoize balancer for a request memoize balancer for a request Jul 26, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2019
@ElvinEfendi
Copy link
Member Author

/test pull-ingress-nginx-test

1 similar comment
@ElvinEfendi
Copy link
Member Author

/test pull-ingress-nginx-test

@codecov-io
Copy link

Codecov Report

Merging #4365 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4365      +/-   ##
=========================================
+ Coverage   58.47%   58.5%   +0.03%     
=========================================
  Files          87      87              
  Lines        6528    6528              
=========================================
+ Hits         3817    3819       +2     
+ Misses       2282    2281       -1     
+ Partials      429     428       -1
Impacted Files Coverage Δ
internal/ingress/metric/collectors/process.go 90.42% <0%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f062d...8f5fa78. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jul 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit daf4a15 into kubernetes:master Jul 26, 2019
@ElvinEfendi ElvinEfendi deleted the fix-balancer-bug branch July 26, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible undefined behavior in balancer.lua
4 participants