Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quote function in template #4423

Merged
merged 1 commit into from
Aug 10, 2019
Merged

Add quote function in template #4423

merged 1 commit into from
Aug 10, 2019

Conversation

adoy
Copy link
Contributor

@adoy adoy commented Aug 9, 2019

Co-authored-by: Charle Demers [email protected]

What this PR does / why we need it: Expose a new function in the template to quote a string in double quotes and make sure that input with a double quote inside the input string will not break the template.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @adoy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 9, 2019
@aledbf
Copy link
Member

aledbf commented Aug 9, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2019
@adoy
Copy link
Contributor Author

adoy commented Aug 9, 2019

/test pull-ingress-nginx-test

@aledbf
Copy link
Member

aledbf commented Aug 9, 2019

/retest

1 similar comment
@aledbf
Copy link
Member

aledbf commented Aug 9, 2019

/retest

@codecov-io
Copy link

codecov-io commented Aug 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8c47219). Click here to learn what that means.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4423   +/-   ##
=========================================
  Coverage          ?   58.81%           
=========================================
  Files             ?       88           
  Lines             ?     6602           
  Branches          ?        0           
=========================================
  Hits              ?     3883           
  Misses            ?     2289           
  Partials          ?      430
Impacted Files Coverage Δ
internal/ingress/controller/template/template.go 83.59% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c47219...f459515. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Aug 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2019
@aledbf
Copy link
Member

aledbf commented Aug 10, 2019

@adoy thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adoy, aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2019
@aledbf
Copy link
Member

aledbf commented Aug 10, 2019

/retest

1 similar comment
@adoy
Copy link
Contributor Author

adoy commented Aug 10, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1926340 into kubernetes:master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants