Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple CA Certificates #4556

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Allow multiple CA Certificates #4556

merged 1 commit into from
Sep 13, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 12, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4234

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2019
@aledbf
Copy link
Member Author

aledbf commented Sep 12, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Sep 12, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Sep 12, 2019

/retest

@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #4556 into master will increase coverage by 0.02%.
The diff coverage is 59.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4556      +/-   ##
==========================================
+ Coverage   59.34%   59.37%   +0.02%     
==========================================
  Files          89       89              
  Lines        6823     6823              
==========================================
+ Hits         4049     4051       +2     
+ Misses       2338     2337       -1     
+ Partials      436      435       -1
Impacted Files Coverage Δ
internal/ingress/sslcert.go 0% <ø> (ø) ⬆️
internal/ingress/controller/store/backend_ssl.go 43.29% <0%> (-3.58%) ⬇️
internal/net/ssl/ssl.go 52.76% <69.56%> (+1.66%) ⬆️
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4f178...8f784df. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple TLS Client Certs: Only the First Certificate is Being Accepted by Nginx
3 participants