Removing secure-verify-ca-secret support

[janosi]

What this PR does / why we need it: The annotation secure-verify-ca-cert is not supported anymore and ignored silently currently. This PR is to remove the relevant code and the relevant parts from the documentation. There is a new error log if the annotation is present in an Ingress definition. Later this log should be removed, too, but currently it serves as a note to the users who currently uses this annotation in their Ingresses.

Which issue this PR fixes: This PR is due to issue #4503 , but the actual fix for the problem of that isse will be handled by issue 4688. I.e. this PR should not close any issues.

Special notes for your reviewer:

[k8s-ci-robot]

Hi @janosi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mhmxs]

This should be an error here.

[janosi]

That is right. Fixing.

[janosi]

/assign @ElvinEfendi

[aledbf]

@janosi please don't assign PRs manually

[aledbf]

/ok-to-test

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@a6815c3). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #4695   +/-   ##
=========================================
  Coverage          ?   58.62%           
=========================================
  Files             ?       88           
  Lines             ?     6743           
  Branches          ?        0           
=========================================
  Hits              ?     3953           
  Misses            ?     2353           
  Partials          ?      437

Impacted Files	Coverage Δ
internal/ingress/types.go	0% <ø> (ø)
internal/ingress/zz_generated.deepcopy.go	0% <ø> (ø)
internal/ingress/types_equals.go	17.39% <ø> (ø)
internal/ingress/controller/controller.go	50.43% <ø> (ø)
...nternal/ingress/annotations/secureupstream/main.go	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6815c3...c76995b. Read the comment docs.

[janosi]

@janosi please don't assign PRs manually

Sure.
This message from the bot above is a bit confusing then
To complete the pull request process, please assign elvinefendi You can assign the PR to them by writing /assign @elvinefendi in a comment when ready.

[aledbf]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, janosi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment