Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move opentracing configuration for location to go #4965

Merged
merged 1 commit into from
Jan 26, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 25, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #4933

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2020
@aledbf aledbf force-pushed the move-logic branch 2 times, most recently from d214b0d to f574386 Compare January 25, 2020 23:18
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@1443ebf). Click here to learn what that means.
The diff coverage is 84.21%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #4965   +/-   ##
========================================
  Coverage          ?   58.5%           
========================================
  Files             ?      88           
  Lines             ?    6736           
  Branches          ?       0           
========================================
  Hits              ?    3941           
  Misses            ?    2363           
  Partials          ?     432
Impacted Files Coverage Δ
internal/ingress/types_equals.go 17.39% <0%> (ø)
internal/ingress/controller/template/template.go 79.82% <100%> (ø)
internal/ingress/annotations/opentracing/main.go 63.63% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1443ebf...d512367. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jan 26, 2020

/retest

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Jan 26, 2020

/retest

@aledbf aledbf merged commit 7ff49b2 into kubernetes:master Jan 26, 2020
@aledbf aledbf deleted the move-logic branch January 26, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to 'enable-opentracing' annotation does not take effect until ingress restarted
3 participants