Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added proxy-ssl-location-only test. #5296

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Added proxy-ssl-location-only test. #5296

merged 1 commit into from
Mar 30, 2020

Conversation

SzekeresB
Copy link
Contributor

What this PR does / why we need it:

Adds missing TC for proxy-ssl-location-only configuration and contains refactoring for rewrite.go TCs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

none

How Has This Been Tested?

make FOCUS="proxy-ssl-*" kind-e2e-test
make FOCUS="rewrite-target use-regex enable-rewrite-log" kind-e2e-test

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @SzekeresB. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2020
@aledbf
Copy link
Member

aledbf commented Mar 26, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2020
aledbf
aledbf reviewed Mar 27, 2020
View reviewed changes
test/e2e/annotations/proxyssl.go Outdated
})
}

func buildIngressWithGivenSecretName(host string, name string, namespace string, annotations map[string]string, tlsHosts []string, secretName string, path string, serviceName string, servicePort int) *networking.Ingress {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reuse framework.NewSingleIngressWithTLS

@aledbf
Copy link
Member

aledbf commented Mar 27, 2020

@SzekeresB please don't change the format in rewrite.go
(It's my fault, we should be using that format and not the one you are changing to)

@SzekeresB SzekeresB changed the title Refactored rewrite.go tests and added proxy-ssl-location-only test. Added proxy-ssl-location-only test. Mar 30, 2020
@codecov-io
Copy link

codecov-io commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #5296 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5296   +/-   ##
=======================================
  Coverage   58.64%   58.64%           
=======================================
  Files          88       88           
  Lines        6901     6901           
=======================================
  Hits         4047     4047           
  Misses       2410     2410           
  Partials      444      444

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b17d3...d362475. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 30, 2020
@aledbf
Copy link
Member

aledbf commented Mar 30, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, SzekeresB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 461aa93 into kubernetes:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf left review comments

@cmluciano cmluciano Awaiting requested review from cmluciano

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SzekeresB @k8s-ci-robot @aledbf @codecov-io