Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuration of plugins using configmap #5331

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 6, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #5196

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2020
@aledbf
Copy link
Member Author

aledbf commented Apr 10, 2020

/retest

@codecov-io
Copy link

Codecov Report

Merging #5331 into master will decrease coverage by 0.07%.
The diff coverage is 61.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5331      +/-   ##
==========================================
- Coverage   58.70%   58.62%   -0.08%     
==========================================
  Files          88       88              
  Lines        6908     6914       +6     
==========================================
- Hits         4055     4053       -2     
- Misses       2410     2416       +6     
- Partials      443      445       +2     
Impacted Files Coverage Δ
cmd/nginx/flags.go 82.38% <ø> (-0.71%) ⬇️
internal/ingress/controller/template/configmap.go 75.58% <0.00%> (-1.82%) ⬇️
internal/ingress/controller/store/store.go 60.08% <66.66%> (+0.12%) ⬆️
internal/ingress/controller/controller.go 49.40% <100.00%> (ø)
internal/ingress/controller/template/template.go 80.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6873a...c0db19b. Read the comment docs.

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 25d37b6 into kubernetes:master Apr 13, 2020
@aledbf aledbf deleted the plugins branch April 13, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to strip ports from the host header (improves istio compatibility)
4 participants