staple only when OCSP response status is "good" #5403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Rel #5397
I have not found any spec for what to do in the server when OCSP response validation fails - let me know if you have a thought!
In the meantime in this PR I'm switching to what vanilla Nginx does - staple iff response status is "good" and response passes other checks in https://github.com/openresty/lua-nginx-module/blob/896638287afd83f060d3f8e9a51b53dbd26d0ae7/src/ngx_http_lua_ssl_ocsp.c#L263.
I think in the world where OCSP must-staple is no prevalent it makes more sense to avoid stapling when OCSP response is invalid. However I still don't get why Nginx considers OCSP response with status "revoked" as invalid.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: