Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staple only when OCSP response status is "good" #5403

Merged
merged 1 commit into from
Apr 19, 2020
Merged

staple only when OCSP response status is "good" #5403

merged 1 commit into from
Apr 19, 2020

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

Rel #5397

I have not found any spec for what to do in the server when OCSP response validation fails - let me know if you have a thought!

In the meantime in this PR I'm switching to what vanilla Nginx does - staple iff response status is "good" and response passes other checks in https://github.com/openresty/lua-nginx-module/blob/896638287afd83f060d3f8e9a51b53dbd26d0ae7/src/ngx_http_lua_ssl_ocsp.c#L263.

I think in the world where OCSP must-staple is no prevalent it makes more sense to avoid stapling when OCSP response is invalid. However I still don't get why Nginx considers OCSP response with status "revoked" as invalid.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 19, 2020
@k8s-ci-robot k8s-ci-robot requested review from bowei and cmluciano April 19, 2020 17:42
@aledbf
Copy link
Member

aledbf commented Apr 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Apr 19, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6d6eba6 into kubernetes:master Apr 19, 2020
@ElvinEfendi ElvinEfendi deleted the staple-when-good branch April 19, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants