feat: add http-access-log-path and stream-access-log-path options in configMap

[agile6v]

What this PR does / why we need it:

Please see issue #5647

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #5647

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Hi @agile6v. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ElvinEfendi]

Can you create e2e test file test/e2e/settings/access_log.go and assert that logic works as expected? You can use f.UpdateNginxConfigMapData helper function to set the setting value, and then use following for assertion:

    f.WaitForNginxConfiguration(func(conf string) bool {
      return strings.Contains(conf, "access_log or something")
    })

[agile6v]

Can you create e2e test file test/e2e/settings/access_log.go and assert that logic works as expected? You can use f.UpdateNginxConfigMapData helper function to set the setting value, and then use following for assertion:

    f.WaitForNginxConfiguration(func(conf string) bool {
      return strings.Contains(conf, "access_log or something")
    })

Thanks for your patient guidance.

[ElvinEfendi]

/ok-to-test

[aledbf]

I understand the reason for this feature but I prefer to remove the access-log setting and use the current value, /var/log/access.log, in the new two fields. Not doing this will trigger questions about the order or priority.

[agile6v]

I understand the reason for this feature but I prefer to remove the access-log setting and use the current value, /var/log/access.log, in the new two fields. Not doing this will trigger questions about the order or priority.

Yes. I also prefer to remove the access-log-path option. But if considering backward compatibility, it's better to deprecate it in the further release. Thanks.

[agile6v]

/retest

[codecov-commenter]

Codecov Report

Merging #5656 into master will increase coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5656      +/-   ##
==========================================
+ Coverage   58.48%   58.72%   +0.24%     
==========================================
  Files          88       88              
  Lines        6975     6946      -29     
==========================================
  Hits         4079     4079              
+ Misses       2446     2417      -29     
  Partials      450      450              

Impacted Files	Coverage Δ
internal/ingress/controller/nginx.go	30.00% <0.00%> (+0.27%)	⬆️
internal/ingress/controller/process/nginx.go	100.00% <ø> (+67.64%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8419bb6...fc1c043. Read the comment docs.

[agile6v]

ping @aledbf @ElvinEfendi

[ElvinEfendi]

I like the idea of removing access-log-path in subsequent releases after deprecating it in the next release.

/lgtm

[ElvinEfendi]

/approve cancel

@aledbf I'll let you approve

[aledbf]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agile6v, aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aledbf]

/retest