bumped go version to 1.18.2

[longwuyuan]

What this PR does / why we need it:

• This PR bumps the go version used in the project to v1.18.1, from v1.17.6

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

fixes #8577

How Has This Been Tested?

• Will be tested in CI when controller image is rebuilt

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

@longwuyuan: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

@rikatz @tao12345666333 first time I am bumping go, so please forgive mistakes and advise next steps on mistakes

[longwuyuan]

/assign @rikatz

[rikatz]

thanks Long!

Some places to be changed as well:

./images/kube-webhook-certgen/rootfs/Dockerfile
15:FROM --platform=$BUILDPLATFORM golang:1.16 as builder
./images/kube-webhook-certgen/rootfs/go.mod
3:go 1.16

./images/custom-error-pages/rootfs/Dockerfile
15:FROM golang:1.17-alpine as builder
./images/custom-error-pages/rootfs/go.mod
3:go 1.17
./images/ext-auth-example-authsvc/rootfs/go.mod
3:go 1.17

And finally the root go.mod should be changed to go v1.18 as well :)

[longwuyuan]

I edited the files you mentioned @rikatz. Please check.

But, just now, I saw v1.18.2 is out as well. So in the spots where there is just 1.18, will it pick up v1.18.2 ?

[longwuyuan]

checking failed tests. maybe should have built & promoted the cetgen and other images first

[ElvinEfendi]

/lgtm

[longwuyuan]

Had forgotten to bump in /go.mod . Re-pushed after bumping in /go.mod as well.

[rikatz]

Yeah let's move to 1.18.2 as it fixes a cve

[rikatz]

/hold cancel

[rikatz]

/hold

[rikatz]

@longwuyuan using go 1.18.2, go to auth-svc and webhook dirs (and also in the main one) and run "go mod tidy"

This will update go.sum and the tests should pass

[longwuyuan]

@rikatz sorry for that. Did that now. Waiting for tests

[rikatz]

@rikatz sorry for that. Did that now. Waiting for tests

no need to ask for sorry, first time doing this right? :D

[longwuyuan]

:-) thanks.
Previously failing tests passed now.

[longwuyuan]

I forgot something else.
We need to put K8S v1.24 also now !
And maybe remove K8s v1.19 !

[rikatz]

We can do that in a separate PR

[rikatz]

/check-cla
/lgtm
/approve
Thanks!

[rikatz]

/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, longwuyuan, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ElvinEfendi,rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rikatz]

@longwuyuan now you need to promote all generated images :)

[longwuyuan]

@rikatz assigned kubernetes/k8s.io#3727 to you for promoting certain and errors images.

(We need to create a repo for other images that we see directories for under /images but don't have a image repo for)