Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error log when no OCSP responder URL exists #8881

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Don't error log when no OCSP responder URL exists #8881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion rootfs/etc/nginx/lua/certificate.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,14 @@ end
-- While this has no functional implications, it generates extra load on OCSP servers.
local function fetch_and_cache_ocsp_response(uid, der_cert)
local url, err = ocsp.get_ocsp_responder_from_der_chain(der_cert)
if not url then
if not url and err then
ngx.log(ngx.ERR, "could not extract OCSP responder URL: ", err)
return
end
if not url and not err then
ngx.log(ngx.DEBUG, "no OCSP responder URL returned")
return
end

local request
request, err = ocsp.create_ocsp_request(der_cert)
Expand Down