Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update base image of nginx to 1.21.6 #9257

Merged
merged 5 commits into from
Nov 6, 2022
Merged

update base image of nginx to 1.21.6 #9257

merged 5 commits into from
Nov 6, 2022

Conversation

strongjz
Copy link
Member

@strongjz strongjz commented Nov 4, 2022

Signed-off-by: James Strong [email protected]

What this PR does / why we need it:

Upgrade nginx to 1.21.6

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ X ] New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.
  • Added Release Notes.
upgrade nginx base image to 1.21.6 build

/triage accepted
/kind feature
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 4, 2022
@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022
@strongjz strongjz force-pushed the update-nginx-1-21-6 branch from 32ae7ae to ca544c6 Compare November 4, 2022 16:42
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2022
@strongjz strongjz force-pushed the update-nginx-1-21-6 branch 2 times, most recently from 6cc6d19 to 67eec10 Compare November 4, 2022 17:16
@strongjz strongjz force-pushed the update-nginx-1-21-6 branch from 67eec10 to 4d199b7 Compare November 4, 2022 17:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2022
@tao12345666333
Copy link
Member

it's 1.21.4 image. I forgot to promote the 1.21.6 version of the image

xref: https://github.com/kubernetes/k8s.io/pull/4398/files

@tao12345666333
Copy link
Member

new PR for 1.21.6 kubernetes/k8s.io#4427

tao12345666333
tao12345666333 requested changes Nov 6, 2022
View reviewed changes
NGINX_BASE Outdated Show resolved Hide resolved
@strongjz @tao12345666333
Update NGINX_BASE
113d02f 
Co-authored-by: Jintao Zhang <[email protected]>
tao12345666333
tao12345666333 approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: strongjz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [strongjz,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4bd7e17 into kubernetes:main Nov 6, 2022
@strongjz strongjz deleted the update-nginx-1-21-6 branch November 8, 2022 15:29
jaehnri pushed a commit to jaehnri/ingress-nginx that referenced this pull request Jan 2, 2023
@strongjz @tao12345666333 @jaehnri
update base image of nginx to 1.21.6 (kubernetes#9257)
b12ec5a 
* add workflow dispatch and update nginx base

Signed-off-by: James Strong <[email protected]>

* e2e were failing, added a go mod tidy

Signed-off-by: James Strong <[email protected]>

* e2e were failing, added a go mod tidy

Signed-off-by: James Strong <[email protected]>

* push mod and sum from main

Signed-off-by: James Strong <[email protected]>

* Update NGINX_BASE

Co-authored-by: Jintao Zhang <[email protected]>

Signed-off-by: James Strong <[email protected]>
Co-authored-by: Jintao Zhang <[email protected]>
@strongjz strongjz mentioned this pull request Mar 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@rikatz rikatz Awaiting requested review from rikatz

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@tao12345666333 tao12345666333

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strongjz @tao12345666333 @k8s-ci-robot