-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all deprecated sets.String with sets.Set #9589
Conversation
…et[string]{} s2 := New[string]() Signed-off-by: Fish-pro <[email protected]>
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Fish-pro thanks for your PR. There is absolutely no details or explaining done in the description section of the PR. I think this looks like some very important improvement. But on the very basics of OSS projects, people who visit this PR or search in future deserve to know details and precise stories with examples and tests. It helps reduce the time a developer needs to get on the same page as you and it also helps improve & document the changes for the users who will use the code.
|
@longwuyuan |
/ok-to-test /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fish-pro, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Thanks @rikatz for the PR review |
Signed-off-by: Fish-pro [email protected]
What this PR does / why we need it:
sets.String is deprecated, replace it with Set
Types of changes
Which issue/s this PR fixes
fixes #9590
How Has This Been Tested?
Checklist: