Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng: setup service account to be used in prow build to access gcb #1620

Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 7, 2021

The PR tries to address the feedback kubernetes/test-infra#20703 (comment) to be able to run pre-submits jobs to trigger GCB

To be honest I'm not sure if those changes are correct. Please let me know what we need to update/create.

Follow up

  • create a check to add some enforcement around which jobs are allowed to use which service accounts via tests in config/tests/jobs in test-infra repo.

Related to kubernetes/release#1850

/assign @spiffxp @hasheddan

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 7, 2021
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold
/assign @dims @spiffxp
Remove hold when ready to deploy

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 7, 2021
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member

spiffxp commented Feb 8, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2021
@spiffxp
Copy link
Member

spiffxp commented Feb 8, 2021

hm, tide is currently saying "Pending — Not mergeable." but the details link says the PR is good to merge

other info:

maybe posting this comment will refresh things?

@k8s-ci-robot k8s-ci-robot merged commit 40cb5e7 into kubernetes:master Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 8, 2021
@spiffxp
Copy link
Member

spiffxp commented Feb 8, 2021

Upon closer inspection this won't quite work, the project names don't quite line up. I'm going to open a followup PR to make a gcb-builder-releng-test@k8s-staging-releng-test service account, and give it GCB and GCR access.

@spiffxp
Copy link
Member

spiffxp commented Feb 9, 2021

Opened #1626

@cpanato cpanato deleted the svcacc-k8s-infra-staging-releng-test branch February 9, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants