Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support imagePullPolicy via label. #1036

Closed
mikesimos opened this issue Jun 6, 2018 · 8 comments
Closed

Support imagePullPolicy via label. #1036

mikesimos opened this issue Jun 6, 2018 · 8 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mikesimos
Copy link

mikesimos commented Jun 6, 2018

Would kompose.image-pull-policy be a good candidate name for this label?

@jvitor83
Copy link
Contributor

The only change i make was the label name, that i use: kompose.service.image-pull-policy

@mikesimos
Copy link
Author

Hi @jvitor83 ! Sorry just saw that. I was waiting for some confirmation/ guidelines for this issue from the project maintainers following contributing guidelines here. I already have some work for own use on this here awaiting to be PRed. Would you mind rebasing your contribution on top of this? Thanks!
The naming of the label is indeed a concern, but since imagePullPolicy isn't a docker-compose service directive, I wouldn't use the kompose.service prefix. I was rather inclined towards something like kubernetes. prefix for kubernetes specific customizations. This feature focuses on very specific use cases were imagePullPolicy Never needs to be specified (ie. industrial air-gapped environments, etc). Not sure if this (check imagePullPolicy) is helpful for you.

@mikesimos
Copy link
Author

@cdrage @hangyan, I m creating a PR for comments/guidelines? Thanks!

@jvitor83
Copy link
Contributor

@mikesimos closing my PR since your appear to do the same (only with different label).

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 16, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants