Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for: stop_grace_period #440

Closed
cdrage opened this issue Feb 22, 2017 · 6 comments · Fixed by #601
Closed

Support for: stop_grace_period #440

cdrage opened this issue Feb 22, 2017 · 6 comments · Fixed by #601
Labels
libcompose

Comments

@cdrage
Copy link
Member

cdrage commented Feb 22, 2017 •
edited
Loading

No error / warning when using this key.
@procrypt
Copy link

procrypt commented Mar 2, 2017

@cdrage Opened up an issue on libcompose.
docker/libcompose#447

@gitlawr
Copy link
Contributor

gitlawr commented May 15, 2017

upstream issue was fixed and we should be able to move on

surajnarwade added a commit to surajnarwade/kompose that referenced this issue May 15, 2017
@surajnarwade
Updated Vendoring
7f00fec 
It resolves issues kubernetes#474 and kubernetes#589 which were coming from libcompose,
as well as resolves kubernetes#440 and kubernetes#437 partially as `group_add` & `stop_grace_period`
are supported by libcompose now.
@surajnarwade surajnarwade mentioned this issue May 15, 2017
Merged
@surajssd
Copy link
Member

@cdrage @surajnarwade asking out of curiousity, where does this map to in k8s? And in code are we handing this info to something?

cdrage pushed a commit to cdrage/kompose that referenced this issue May 17, 2017
@surajnarwade @cdrage
Updated Vendoring
29ef355 
It resolves issues kubernetes#474 and kubernetes#589 which were coming from libcompose,
as well as resolves kubernetes#440 and kubernetes#437 partially as `group_add` & `stop_grace_period`
are supported by libcompose now.
@gitlawr
Copy link
Contributor

gitlawr commented May 18, 2017

@surajssd I think stop_grace_period can be mapped to Pod.Spec.TerminationGracePeriodSeconds.
This issue hasn't been solved yet. Still no warning/error when using this key.

gitlawr added a commit to gitlawr/kompose that referenced this issue May 18, 2017
@gitlawr
To solve kubernetes#440
e67c0f3 
This commit Add support for stop_grace_period which maps to
Pod.Spec.TerminationGracePeriodSeconds
Updated conversion.md on support for the key
@gitlawr gitlawr mentioned this issue May 18, 2017
Merged
@surajnarwade
Copy link
Contributor

surajnarwade commented May 18, 2017 •
edited
Loading

@surajssd , can you please reopen the issue ?
I agree with @gitlawr

@cdrage cdrage reopened this May 18, 2017
gitlawr added a commit to gitlawr/kompose that referenced this issue May 23, 2017
@gitlawr
To solve kubernetes#440
c01f6f1 
This commit Add support for stop_grace_period which maps to
Pod.Spec.TerminationGracePeriodSeconds
Updated conversion.md on support for the key
@surajssd
Copy link
Member

closed by #608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libcompose
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated Vendoring surajnarwade/kompose
6 participants
@kadel @gitlawr @surajssd @cdrage @procrypt @surajnarwade