Consider changing --rc flag to bool and adding --replicas

[janetkuo]

Right now all flags for specifying controller types are bool, except for --rc, which is int.

This is confusing because I cannot do this

$ ../kompose convert --rc -y
Incorrect Usage.

And this (surprisingly) gives me a deployment

$ ../kompose convert --rc="0" -y
file "redis-svc.yaml" created
file "web-svc.yaml" created
file "redis-deployment.yaml" created
file "web-deployment.yaml" created

I propose that we change --rc back to bool and add another int flag for specifying replicas, since other controllers also take replicas in their spec. We can default it to -1 as unset, and then we don't specify it in spec (and let K8s API server decide the default value). If it's set to something >= 0, we set it explicitly.

[ngtuna]

+1. Are u going to do or shoud I take it?

[janetkuo]

I can take this one
On Thu, Jul 21, 2016 at 7:33 PM Tuna [email protected] wrote:

+1. Are u going to do or shoud I take it?

—
You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEpqQxaBI4-E2R7SXy2ICxUnr-k2ARuEks5qYCwRgaJpZM4JSVIn
.