Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to annotations / cli tests + development document #770

Closed
cdrage opened this issue Aug 16, 2017 · 11 comments
Closed

Update to annotations / cli tests + development document #770

cdrage opened this issue Aug 16, 2017 · 11 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@cdrage
Copy link
Member

cdrage commented Aug 16, 2017

So there's two issues I'm encountering with annotations:

  1. If there is no kompose, it does not error out. For example, if Kompose is not within $GOPATH or /usr/local/bin, then the annotation is blank for VERSION.
  2. Tests need to be updated.. Using sed seems like a hack at the moment and it should be refactored (in the future)

Ping @surajnarwade

@cdrage
Copy link
Member Author

cdrage commented Aug 16, 2017

Another suggestion as well is after fixing issue 1 we implement a small script that passes in a file name and automatically adds the "test" to tests.sh as it's fairly difficult / troublesome to manually create all the test outputs as well as modify it so %VERSION% and `%CMD% is there for the annotations.

@surajnarwade
Copy link
Contributor

surajnarwade commented Aug 17, 2017

@cdrage that script is already on my list :)

@cdrage
Copy link
Member Author

cdrage commented Aug 18, 2017

@surajnarwade can you work on option 1. as well?

@cdrage cdrage changed the title Issues with annotations Update to annotations / cli tests + development document Aug 30, 2017
@ashetty1
Copy link
Contributor

Taking this up

@cdrage cdrage added this to the 1.2.0 release milestone Aug 30, 2017
@surajnarwade
Copy link
Contributor

documentation issue: #781

@cdrage cdrage modified the milestones: 1.3.0 release, 1.4.0 release Oct 10, 2017
@cdrage cdrage modified the milestones: 1.4.0 release, 1.5.0 release Oct 31, 2017
@cdrage cdrage removed this from the 1.5.0 release milestone Jan 24, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 28, 2018
@surajnarwade
Copy link
Contributor

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 6, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2018
@cdrage
Copy link
Member Author

cdrage commented Jun 4, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2018
@cdrage cdrage closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants