[WIP] Update to use ./kompose instead of $GOPATH kompose binary #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
@cdrage, thank you for the pull request! We'll ping some people to review your PR. @surajnarwade and @procrypt, please review this. |
The issue is that when running `make test-cmd` you'll have to cp kompose to the /usr/local/bin directory or the $GOPATH directory. Since `make test` is being used consistently in the same git diretory, it makes sense to use the local-built binary.
|
Blocked on #770 since |
surajnarwade
approved these changes
Aug 18, 2017
kadel
reviewed
Oct 2, 2017
| @@ -4,9 +4,6 @@ sudo: required | |||
|
|
|||
| language: go | |||
|
|
|||
| # make this also work for forks | |||
| go_import_path: github.com/kubernetes/kompose | |||
There was a problem hiding this comment.
Why is this removed? It shouldn't have any effect on this, or does it?
There was a problem hiding this comment.
Yeah, I need to re-work this...
cdrage
changed the title
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that when running
make test-cmdyou'll have to cp komposeto the /usr/local/bin directory or the $GOPATH directory.
Since
make testis being used consistently in the same git diretory,it makes sense to use the local-built binary.