-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump Go version and github.com/compose-spec/compose-go #1838
Conversation
Welcome @microsec-ambrose! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @microsec-ambrose for the changes. Some things are broken now. Do you have some time to commit to fix them?
compose-go only supports 1.21 and above due to the use of the I have updated the PR to upgrade Go too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! Been a busy past couple of weeks for me.
Awesome changes, just one comment about a test, but that's it.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: microsec-ambrose, TessaIO The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Upgrades
compose-go
to support the newconfig
syntax.Currently, any output from
docker compose config
includingenv_files
is not accepted by Kompose. Docker Compose v2.24.7 changed the output schema.See docker/compose#11591 (comment)
Which issue(s) this PR fixes:
N.A.
Special notes for your reviewer: