make kompose go get-able #227
Conversation
|
I was implying the CLI be go-getable in #216 |
|
@ericchiang you mean |
|
@ngtuna I was implying renaming the package So at minimum |
|
It's obviously not critical. But it's pretty standard for Go projects :) |
|
Okay thanks @ericchiang for pointing it out. It's pretty easy to rename the package. I will consider more on removing experimental tag of bundlefile. |
ngtuna
force-pushed
the
go-getable
branch
2 times, most recently
from
f5c2303 to
ba8934a
Compare
|
@ericchiang I see it would be better to move main/main.go to the parent directory but not sure if it violates the standard of kubenertes-incubator or not. That is a bit of weird in path of the package when doing $ go get github.com/kubernetes-incubator/kompose |
I'm for this (but that's just a preference). |
|
Works for me but I can't officially review so it's not worth much. |
|
ping @ericchiang @kadel Could you add your review on this ? |
|
lgtm but I'll let @kadel add the review. |
| @@ -40,6 +40,12 @@ tar -xvf kompose_linux-amd64.tar.gz --strip 1 | |||
| sudo mv kompose /usr/local/bin | |||
| ``` | |||
|
|
|||
| Otherwise, you could take the latest development package from master branch. Make sure your PATH includes the $GOPATH/bin directory so your commands can be easily used: | |||
|
I found that $ make binary
CGO_ENABLED=1 ./script/make.sh binary
---> Making bundle: binary (in .)
# command-line-arguments
./main.go:35: cannot use command.BeforeApp (type func(*"github.com/kubernetes-incubator/kompose/vendor/github.com/urfave/cli".Context) error) as type func(*"github.com/skippbox/kompose/vendor/github.com/urfave/cli".Context) error in assignment
./main.go:36: cannot use append(command.CommonFlags()) (type []"github.com/kubernetes-incubator/kompose/vendor/github.com/urfave/cli".Flag) as type []"github.com/skippbox/kompose/vendor/github.com/urfave/cli".Flag in assignment
./main.go:40: cannot use command.ConvertCommandDummy() (type "github.com/kubernetes-incubator/kompose/vendor/github.com/urfave/cli".Command) as type "github.com/skippbox/kompose/vendor/github.com/urfave/cli".Command in array or slice literal
./main.go:44: cannot use command.UpCommand() (type "github.com/kubernetes-incubator/kompose/vendor/github.com/urfave/cli".Command) as type "github.com/skippbox/kompose/vendor/github.com/urfave/cli".Command in array or slice literal
./main.go:45: cannot use command.DownCommand() (type "github.com/kubernetes-incubator/kompose/vendor/github.com/urfave/cli".Command) as type "github.com/skippbox/kompose/vendor/github.com/urfave/cli".Command in array or slice literal
make: *** [binary] Error 2 |
Could you re-run it ? I just run |
From the error log it seems that it's because I'm still using skippbox/kompose/
|
kadel
added
the
lgtm
|
Merging |
Fix #216