-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to 'make bin' instead of 'make binary' #302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, if we want to modify this we should:
- Add the license header
- Make
make
the default which creates the binary - change
binary-cross
tocross
- Make
all
target also runs the validation checks...
@sebgoa do we really need to put a license header in every file? Not even Docker has that (and it's pretty much the largest Go project out there: https://github.com/docker/docker/blob/master/Makefile) |
0221c14
to
caab297
Compare
@sebgoa |
added ;-) |
caab297
to
7851fc1
Compare
@cdrage don't forget to update .travis.yml 😉 |
@cdrage and yes we need the license header. I don't care what Docker does. Any file that does not have the license header is not properly licensed.. that's how you apply an ASL license throughout your code base. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, need an updated travis file.
@@ -89,7 +89,7 @@ $ CGO_ENABLED=0 GO15VENDOREXPERIMENT=1 go build -o kompose main.go | |||
To create a multi-platform binary, use the `binary-cross` command via `make`: | |||
|
|||
```console | |||
$ make binary-cross | |||
$ make bin-cross |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Makefile uses the cross
target not the bin-cross
?
7851fc1
to
5151b2a
Compare
@sebgoa done. added license and updated readme. |
well, lots of travis errors |
I keep mistyping this when creating the binary as per other projects that use it commonly (it's usually `make bin` instead of `make binary`).
5151b2a
to
c87e6cd
Compare
@sebgoa Travis passes now. Forgot to update |
I keep mistyping this when creating the binary as per other projects
that use it commonly (it's usually
make bin
instead ofmake binary
).