add stdin_open, tty support, add tests, fix #344 #350
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
| @@ -428,6 +434,8 @@ func (k *Kubernetes) InitPod(name string, service kobject.ServiceConfig) *api.Po | |||
| { | |||
| Name: name, | |||
| Image: service.Image, | |||
| Stdin: service.Stdin, | |||
| TTY: service.Tty, | |||
There was a problem hiding this comment.
as opposed to doing it in multiple places you can do it in one place https://github.com/kubernetes-incubator/kompose/blob/master/pkg/transformer/kubernetes/k8sutils.go#L327
| @@ -60,6 +62,15 @@ func TestInitDeploymentConfig(t *testing.T) { | |||
| if spec.Spec.Triggers[1].ImageChangeParams.ContainerNames[0] != "myfoobarname" { | |||
| t.Errorf("Expected myfoobarname for name, actual %s", spec.Spec.Triggers[1].ImageChangeParams.ContainerNames[0]) | |||
| } | |||
|
|
|||
| if spec.Spec.Template.Spec.Containers[0].Stdin != true { | |||
There was a problem hiding this comment.
Can we create a separate test? Because, this test gets hidden and never shows on output as this was tested?
There was a problem hiding this comment.
Added another test instead of this!
| func TestOpenShiftUpdateKubernetesObjects(t *testing.T) { | ||
| var object []runtime.Object | ||
| o := OpenShift{} | ||
| serviceConfig := newServiceConfig() |
There was a problem hiding this comment.
A log saying what this test runs will help.
There was a problem hiding this comment.
Similar comments are missing in other tests!
There was a problem hiding this comment.
Fixed for TestOpenShiftUpdateKubernetesObjects, log messages for other tests should go in another PR. Tracked at #351
|
apart from those two comments LGTM! |
This adds supports for stdin_open: bool and tty: bool support for kubernetes and openshift providers in kompose. This maps to the template.Spec.Containers[0].Stdin and template.Spec.Containers[0].TTY in Kubernets world. Also, added tests. Fixes kubernetes#344
surajssd
added
the
lgtm
|
@containscafeine awesome work 👍 |
This adds supports for stdin_open: bool and
tty: bool support for kubernetes and openshift
providers in kompose. This maps to the
template.Spec.Containers[0].Stdin and
template.Spec.Containers[0].TTY in Kubernets
world.
Also, added tests.
Fixes #344