removed unnecessary objects in compose.go #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
surajssd
commented
Feb 14, 2017
| logrus.Fatalf("%q failed to load ports from compose file: %v", name, err) | ||
| } | ||
| serviceConfig.Port = ports | ||
| for name, composeServiceConfig := range composeObject.ServiceConfigs.All() { |
There was a problem hiding this comment.
Below this line code is as it is, only for loop has changed and the unncecessary things above are removed.
In compoese.go while iterating on the ServiceConfig objects first it's keys were pulled and then data was pulled separately which can be done in one step by iterating on the dictionary.
surajssd
force-pushed
the
remove_unnecessary_objects
branch
from
d0b1d32 to
775f501
Compare
|
ping @kadel |
kadel
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
compoese.gowhile iterating on theServiceConfigobjects first it's keys were pulled and then data was pulled separately which can be done in one step by iterating on the dictionary.