Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing doc for reviewing, update owners file #527

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Mar 30, 2017

Owners file currently isn't being used (unless we have the Kubernetes
bot in-use), however, it needed a well-overdue update.

I've gone ahead and updated the CONTRIBUTING.md doc to add the change
that it requires two reviews for a code-review and one for a doc
review.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2017
@kadel
Copy link
Member

kadel commented Apr 3, 2017

few stupid questions as always 😇
What is difference between assignees, reviewers and reviewers in OWNERS file?

It might be better to write names in alphabetical order, it will easier to find name there.

Are we going to require 2 acks for every code PR?
I know that we discussed that before, and decided that we will do it only for some PR, but didn't set any rules around that :-(
I'm OK with requiring 2 ack from now on, we can try it to see how much it will slow us down, or if at all.

@cdrage
Copy link
Member Author

cdrage commented Apr 3, 2017

@kadel

It's to do with their "mungebot" for merging. Difference is that you can /lgtm to the bot as an reviewer, same as the asignee. Approvers of course are able to /merge the PR with mungebot.

Honestly, I doubt we're going to use mungebot here (I've tried configuring it once before and found it too cumbersome for our needs), but it's nice to have consistency here.

👍 for two ack's comment. If it slows us down let's switch back to one ack. Or we could have it that it's 1 maintainer ack and 1 other maintainer OR non-maintainer ack.

@kadel
Copy link
Member

kadel commented Apr 3, 2017

OK, lets go with 2 maintainers lgtm for now, if will be too much we can relax rules to 1 maintainer and one other.

There is no way to enforce 2 lgtms without bot :-(, we will have to keep that in mind and trust each other.

@surajssd
Copy link
Member

surajssd commented Apr 3, 2017

@cdrage my username is added twice in reviewer section, i think you wanted to add @surajnarwade

@cdrage cdrage force-pushed the update-authors-and-contributing branch from 14dcf51 to 4946344 Compare April 4, 2017 13:12
@cdrage
Copy link
Member Author

cdrage commented Apr 4, 2017

@surajssd Updated! Just need another review and then we can merge this in.

Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty please, can you sort names alphabetically?

OWNERS Outdated
- kadel
- surajssd
- cdrage
- tkral
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not me ;-)
it should be here.

Owners file currently isn't being used (unless we have the Kubernetes
bot in-use), however, it needed a well-overdue update.

I've gone ahead and updated the CONTRIBUTING.md doc to add the change
that it requires *two* reviews for a code-review and one for a doc
review.
@cdrage cdrage force-pushed the update-authors-and-contributing branch from 4946344 to 7cfc493 Compare April 6, 2017 17:01
@cdrage
Copy link
Member Author

cdrage commented Apr 6, 2017

@kadel Done!

@kadel kadel merged commit d933317 into kubernetes:master Apr 6, 2017
@cdrage cdrage deleted the update-authors-and-contributing branch April 19, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants