-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributing doc for reviewing, update owners file #527
Update contributing doc for reviewing, update owners file #527
Conversation
few stupid questions as always 😇 It might be better to write names in alphabetical order, it will easier to find name there. Are we going to require 2 acks for every code PR? |
It's to do with their "mungebot" for merging. Difference is that you can /lgtm to the bot as an reviewer, same as the asignee. Approvers of course are able to /merge the PR with mungebot. Honestly, I doubt we're going to use mungebot here (I've tried configuring it once before and found it too cumbersome for our needs), but it's nice to have consistency here. 👍 for two ack's comment. If it slows us down let's switch back to one ack. Or we could have it that it's 1 maintainer ack and 1 other maintainer OR non-maintainer ack. |
OK, lets go with 2 maintainers lgtm for now, if will be too much we can relax rules to 1 maintainer and one other. There is no way to enforce 2 lgtms without bot :-(, we will have to keep that in mind and trust each other. |
@cdrage my username is added twice in reviewer section, i think you wanted to add @surajnarwade |
14dcf51
to
4946344
Compare
@surajssd Updated! Just need another review and then we can merge this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty please, can you sort names alphabetically?
OWNERS
Outdated
- kadel | ||
- surajssd | ||
- cdrage | ||
- tkral |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not me ;-)
it should be here.
Owners file currently isn't being used (unless we have the Kubernetes bot in-use), however, it needed a well-overdue update. I've gone ahead and updated the CONTRIBUTING.md doc to add the change that it requires *two* reviews for a code-review and one for a doc review.
4946344
to
7cfc493
Compare
@kadel Done! |
Owners file currently isn't being used (unless we have the Kubernetes
bot in-use), however, it needed a well-overdue update.
I've gone ahead and updated the CONTRIBUTING.md doc to add the change
that it requires two reviews for a code-review and one for a doc
review.