-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Jenkinsfile for PR pipeline on Fabric8CD infrastructure #669
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I have signed the CLA |
@rupalibehera you commit is created with your redhat email. It looks like you don't have that email associated with you github account. You might have to add redhat email to your github account or use the same email that you are using on github for that commit. |
Thanks @kadel I just added my redhat email-id to github account, hopefully it works. |
CLA has been passed. @rupalibehera Any way we could test this / authorize this / see what happens? Have you tested this against your Kompose fork? Let us know! This saves us having to merge this in, then merge something else, unmerge, etc just to get it test to see if it works. Code LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cdrage , I have tested this against my kompose fork. |
def dummy | ||
goTemplate{ | ||
dockerNode{ | ||
goMake{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could add a check to see if the pipeline is part of a CI or CD. I.e. we dont want to run the release if we are running CI builds on Pull Requests. You could do something like this https://github.com/fabric8io/fabric8-init-tenant/blob/master/Jenkinsfile#L9-L24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also what this would do is run your CI pipelines for pull requests, it will create a snapshot image and add a comment to the PR once it's available for testing. Like this fabric8-services/fabric8-tenant#125 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So they just want CI and they are not looking for CD, this pipeline should run on PR and also while the PR is merged to master. Hence I did not explicitly check if it is CI or CD.
@pradeepto and @cdrage could you please confirm this ?
I am not sure if we still add this at least for the snapshot.
@rawlingsj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rupalibehera Yeah, we just want CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok sounds good LGTM
Initial commit adding Jenkinsfile for pr pipeline on fabric8CD(http://jenkins.cd.k8s.fabric8.io/job/kubernetes-incubator/)
This PR includes a Jenkinsfile which just does
make test
for now which will run the tests on every PR and on merge with master.It uses golang version 1.8.1
The below things are not covered which are there in .travis.yml: