Fixed tmpfs with mode failure #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@surajnarwade, thank you for the pull request! We'll request some people to review your PR. @procrypt and @cdrage, please review this. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
cdrage
requested changes
Sep 14, 2017
| @@ -351,7 +352,8 @@ func (k *Kubernetes) ConfigTmpfs(name string, service kobject.ServiceConfig) ([] | |||
| for index, volume := range service.TmpFs { | |||
| //naming volumes if multiple tmpfs are provided | |||
| volumeName := fmt.Sprintf("%s-tmpfs%d", name, index) | |||
|
|
|||
| v := strings.Split(volume, ":") | |||
| volume = v[0] | |||
There was a problem hiding this comment.
this could be just volume = strings.Split(volume, ":") remove the other line
There was a problem hiding this comment.
No, it will not work,
# github.com/kubernetes/kompose/pkg/transformer/kubernetes
pkg/transformer/kubernetes/kubernetes.go:355: cannot use strings.Split(volume, ":") (type []string) as type string in assignment
There was a problem hiding this comment.
@surajnarwade Pretty easy to figure it out, I forgot to add the [0].
Do: strings.Split(volume, ":")[0]
surajnarwade
force-pushed
the
tmpfsfix
branch
from
faf621f to
18ffd3b
Compare
k8s-ci-robot
added
size/XS
|
issue is being tracked here #807 |
|
@surajnarwade can you add tests? After that, LGTM. |
Fixes kubernetes#807 now kompose will ignore mode of tmpfs and will pass only mount path.
surajnarwade
force-pushed
the
tmpfsfix
branch
from
18ffd3b to
8a19c47
Compare
k8s-ci-robot
added
size/L
|
added functional test |
cdrage
approved these changes
Sep 26, 2017
|
LGTM! Thanks for adding the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #807
now kompose will ignore mode of tmpfs and will pass only mount path.