Added Case for Config Map in kompose down #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
piyush-garg
force-pushed
the
iss_kompose_down
branch
from
19324ca to
88a763e
Compare
|
@surajnarwade @cdrage Please review !! |
piyush-garg
force-pushed
the
iss_kompose_down
branch
from
88a763e to
d049022
Compare
k8s-ci-robot
added
size/M
piyush-garg
force-pushed
the
iss_kompose_down
branch
from
d049022 to
7e5d53a
Compare
To implement this, added label in configmap object at the time of init Fixed ConfigMap test because we are adding one more field labels in metadata
piyush-garg
force-pushed
the
iss_kompose_down
branch
from
7e5d53a to
52f8f1f
Compare
|
This LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Case for Config Map in kompose down. To implement this, added a label in the configMap object at the time of init.
It will delete the configMap object during
kompose down#883